Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r427291901
##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -309,6 +309,9 @@ llvm::Type* CodeGenLLVM::DTypeToLLVMType(const DataType&
dtype) const {
default:
LOG(FATAL) << "do not support " << dtype;
}
+ } else if (dtype.is_bfloat()) {
+ CHECK_EQ(dtype.bits(), 16);
Review comment:
Sorry for the inclarity. I think in bfloat[X], only X=16 makes sense.
But TVM's type system allows specifying the `bits` of a type. So here is the
checking to make sure it is bf16.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
