tqchen commented on a change in pull request #5618:
URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r427561396
##########
File path: src/arith/util.cc
##########
@@ -27,6 +27,16 @@
namespace tvm {
namespace arith {
+int gcd(int a, int b) {
Review comment:
gcd -> GreatestCommonDivisor
##########
File path: src/arith/util.cc
##########
@@ -49,5 +59,9 @@ std::tuple<int64_t, int64_t, int64_t> xgcd(int64_t a, int64_t
b) {
return std::make_tuple(old_r, old_s, old_t);
}
+int lcm(int a, int b) {
Review comment:
lcm -> LeastCommonMultiple
##########
File path: src/arith/util.cc
##########
@@ -27,6 +27,16 @@
namespace tvm {
namespace arith {
Review comment:
util-> utils (as per our previous discussion)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
