sergei-grechanik commented on a change in pull request #5618:
URL: https://github.com/apache/incubator-tvm/pull/5618#discussion_r441904864



##########
File path: include/tvm/arith/int_solver.h
##########
@@ -191,6 +275,30 @@ void 
SmithNormalFormDiag(std::vector<std::vector<int64_t>>* S, std::vector<std::
  */
 IntConstraintsTransform SolveLinearEquations(const IntConstraints& 
system_to_solve);
 
+/*!
+ * \brief Solve linear inequalities.
+ * \param system_to_solve the variables to solve, their ranges, and a list of 
inequalities.
+ * \return A map of variables and their solved bounds,
+ *         and constrains that cannot be solved to bounds.
+ */
+PartialSolvedInequalities SolveLinearInequalities(const IntConstraints& 
system_to_solve);
+
+/*!
+ * \brief Solve linear inequalities.
+ * \param system_to_solve the variables to solve, their ranges, and a list of 
inequalities.
+ * \return The result ranges for each variables.
+ *         Constrains that cannot be transformed to Range will be stored in 
relations.
+ */
+IntConstraints SolveInequalitiesToRange(const IntConstraints& system_to_solve);

Review comment:
       I would add some note on how the relations will look like, similarly to 
this: 
https://github.com/sergei-grechanik/tvm/blob/8cad2d1e62272b3e192bfe08b896e07bc9550e94/src/pass/zero_elimination.h#L227




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to