mbrookhart commented on pull request #5646: URL: https://github.com/apache/incubator-tvm/pull/5646#issuecomment-632379884
@mbaret Okay, took a look at the type system. I'm actually passing you the original expression to check, not the partitioned version, so i don't think it will be a problem. That being said, I am not propagating type information through partitioning, in part because I'm not sure at what stage of the compiler passes it will be used, and it would fail if someone tries to run this before type inference. I am, however, I'm running InferTypes as part of the matcher for TypePatterns, so maybe I should just add the requirement that the inputs need to have well formed types and the pass will run InferTypes by default. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
