comaniac commented on pull request #5646: URL: https://github.com/apache/incubator-tvm/pull/5646#issuecomment-632382263
There is only one issue that we need to think of about the type propagation. The reason merge composite (and some other BYOC passes) needs to manually propagate type is that later processed nodes may need to check the type of its arguments (such as the check example in this PR). Since the argument node may be the CallNode that we created for the partitioned function, we need to set up the type to make the check function work. On the other hand, I am thinking that if we make sure all argument accesses are based on the `pre` node instead of `post` node, then manual type propagation may not be an issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
