giuseros commented on a change in pull request #5754:
URL: https://github.com/apache/incubator-tvm/pull/5754#discussion_r440711660
##########
File path: python/tvm/relay/op/nn/nn.py
##########
@@ -2134,6 +2202,25 @@ def contrib_conv2d_winograd_weight_transform(weight,
return _make.contrib_conv2d_winograd_weight_transform(weight, tile_size)
+def contrib_conv2d_gemm_weight_transform(weights):
Review comment:
I added the assert in `conv2d_alter_op.py` as done for Winograd. Also, I
am asserting the (input and kernel) layouts in
[Conv2dGemmRel](https://github.com/apache/incubator-tvm/pull/5754/files#diff-d16c1ec50ceaac0e06f963a425d325b4R568),
still following the approach used by Winograd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
