jcf94 commented on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650022894
> Thanks @jcf94 we should add a testcase to test_arith_rewrite_simplify, by constructing the case and > > * verify each of the rule added in this PR. > * Use `isinstance(x, tvm.ir.Ramp)` to assert the ramp node > * You mentioned a bug in the previous rule, it would be great if the testcase covers the bug you mentioned Commemts are all addressed. - Add several test cases in tests_arith_rewrite_simplify for simplify rules - Update test_target_codegen_cuda UTs & use pre post function to check the RampNode patterns - The bug metioned above is introduced by our former implementation, currently everything work fine ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
