jcf94 commented on pull request #5924:
URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223
> @jcf94 Did our old rule affect the correctness of common operators?
Yes, with those rules several other UTs will fail, they're actually not
always correct.
For example we have:
```
TVM_TRY_REWRITE_IF(floordiv(x * c1 + y, c2), floordiv(x * c1, c2),
c1.Eval()->value > 0 && c2.Eval()->value > 0 &&
c2.Eval()->value % c1.Eval()->value == 0 &&
CanProveGreaterEqual(-y.Eval(), -c1.Eval()->value +
1));
```
while `floordiv(x * 4 + 4, 8)` cannot be simplified to `floordiv(x * 4, 8)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
