mbrookhart commented on a change in pull request #6008:
URL: https://github.com/apache/incubator-tvm/pull/6008#discussion_r452375570
##########
File path: src/relay/transforms/dynamic_to_static.cc
##########
@@ -33,7 +34,9 @@ namespace relay {
class DynamicToStaticMutator : public MixedModeMutator {
public:
DynamicToStaticMutator()
- : dyn_reshape_op_(Op::Get("dyn.reshape")),
dyn_tile_op_(Op::Get("dyn.tile")) {}
+ : dyn_reshape_op_(Op::Get("dyn.reshape")),
Review comment:
I'm thinking a Registry will be the best combination, we can do a
dynamic lookup to see if the op is registered, simplify this codebase, and
still have the caching optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
