lixiaoquan commented on a change in pull request #6008:
URL: https://github.com/apache/incubator-tvm/pull/6008#discussion_r452579414
##########
File path: python/tvm/relay/op/algorithm.py
##########
@@ -82,9 +84,12 @@ def topk(data, k=1, axis=-1, ret_type="both",
out : relay.Expr or List[relay.Expr]
The computed result.
"""
- if isinstance(k, int):
- k = const(k, "int64")
- out = _make.topk(data, k, axis, ret_type, is_ascend, dtype)
+ if isinstance(k, Constant):
+ k = np.asscalar(k.data.asnumpy())
+ if isinstance(k, Expr):
Review comment:
> Thanks for pointing that out, I just realize 'static' version op still
have some dynamic shape handling ability. I think I misunderstood 'dyn'
namespace before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
