tqchen commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r452977944
########## File path: src/runtime/graph/graph_runtime_factory.h ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/runtime/graph_runtime_factory.h + * \brief Graph runtime factory creating graph runtime. + */ + +#ifndef TVM_RUNTIME_GRAPH_GRAPH_RUNTIME_FACTORY_H_ +#define TVM_RUNTIME_GRAPH_GRAPH_RUNTIME_FACTORY_H_ + +#include <tvm/node/container.h> +#include <tvm/runtime/c_runtime_api.h> +#include <tvm/runtime/module.h> +#include <tvm/runtime/ndarray.h> +#include <tvm/runtime/packed_func.h> + +#include <algorithm> +#include <functional> +#include <numeric> +#include <string> +#include <unordered_map> +#include <vector> + +#include "./graph_runtime.h" + +namespace tvm { +namespace runtime { + +class TVM_DLL GraphRuntimeFactory : public runtime::ModuleNode { + public: + /*! + * \brief Initialize the GraphRuntimeFactory with graph and context. + * \param graph_json The execution graph. + * \param params The params of graph. + * \param module_name The module name of graph. + */ + void Init(const std::string& graph_json, const tvm::Map<String, tvm::runtime::NDArray>& params, Review comment: Make them as params of constructor? ########## File path: src/runtime/graph/graph_runtime_factory.cc ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file graph_runtime_factory.cc + * \brief Graph runtime factory implementations + */ + +#include "./graph_runtime_factory.h" + +#include <tvm/node/container.h> +#include <tvm/runtime/device_api.h> +#include <tvm/runtime/registry.h> + +#include <iterator> +#include <vector> + +namespace tvm { +namespace runtime { + +void GraphRuntimeFactory::Init(const std::string& graph_json, + const tvm::Map<String, tvm::runtime::NDArray>& params, + const std::string& module_name) { + graph_json_ = graph_json; + params_ = params; + module_name_ = module_name; +} + +PackedFunc GraphRuntimeFactory::GetFunction( + const std::string& name, const tvm::runtime::ObjectPtr<tvm::runtime::Object>& sptr_to_self) { + if (name == "get_json") { + return PackedFunc( + [sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv = this->GetJson(); }); + } else if (name == "get_lib") { + return PackedFunc( + [sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv = this->GetLib(); }); + } else if (name == "get_params") { + return PackedFunc( + [sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv = this->GetParams(); }); + } else if (name == module_name_) { + return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { + auto module = this->SelectModule(module_name_); + std::vector<TVMContext> contexts; + for (int i = 0; i < args.num_args; ++i) { + contexts.emplace_back(args[i].operator TVMContext()); + } + *rv = this->RuntimeCreate(module, contexts); + }); + } else if (name == "debug_create") { + return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { + CHECK_GE(args.size(), 2); + std::string module_name = args[0].operator String(); + auto module = this->SelectModule(module_name); + std::vector<TVMContext> contexts; + for (int i = 1; i < args.num_args; ++i) { + contexts.emplace_back(args[i].operator TVMContext()); + } + *rv = this->DebugRuntimeCreate(module, contexts); + }); + } else if (name == "remove_params") { + return PackedFunc([sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { + auto exec = make_object<GraphRuntimeFactory>(); + exec->Init(this->GetJson(), {}, this->GetModuleName()); + exec->Import(this->GetLib()); + *rv = Module(exec); + }); + } else { + return PackedFunc(); + } +} + +void GraphRuntimeFactory::SaveToBinary(dmlc::Stream* stream) { + stream->Write(graph_json_); + std::vector<std::string> names; + std::vector<DLTensor*> arrays; + for (const auto& v : params_) { + names.emplace_back(v.first); + arrays.emplace_back(const_cast<DLTensor*>(v.second.operator->())); + } + uint64_t sz = arrays.size(); + CHECK(sz == names.size()); + stream->Write(sz); + stream->Write(names); + for (size_t i = 0; i < sz; ++i) { + tvm::runtime::SaveDLTensor(stream, arrays[i]); + } + stream->Write(module_name_); +} + +Module GraphRuntimeFactory::RuntimeCreate(Module module, const std::vector<TVMContext>& ctxs) { + auto factory_module = module.as<GraphRuntimeFactory>(); + CHECK(factory_module != nullptr); + auto exec = make_object<GraphRuntime>(); + exec->Init(factory_module->GetJson(), factory_module->GetLib(), ctxs); + // set params + SetParams(exec.get(), factory_module->GetParams()); + return Module(exec); +} + +Module GraphRuntimeFactory::DebugRuntimeCreate(Module module, const std::vector<TVMContext>& ctxs) { + auto factory_module = module.as<GraphRuntimeFactory>(); + CHECK(factory_module != nullptr); + const PackedFunc* pf = tvm::runtime::Registry::Get("tvm.graph_runtime_debug.create"); + CHECK(pf != nullptr) << "Cannot find function tvm.graph_runtime_debug.create in registry. " + "Do you enable debug graph runtime build?"; + // Debug runtime create packed function will call GetAllContexs, so we unpack the ctxs. + std::vector<int> unpacked_ctxs; + for (const auto& ctx : ctxs) { + unpacked_ctxs.emplace_back(ctx.device_type); + unpacked_ctxs.emplace_back(ctx.device_id); + } + size_t args_size = unpacked_ctxs.size() + 2; + std::vector<TVMValue> values(args_size); + std::vector<int> codes(args_size); + runtime::TVMArgsSetter setter(values.data(), codes.data()); + setter(0, factory_module->GetJson()); + setter(1, factory_module->GetLib()); + for (size_t i = 0; i < unpacked_ctxs.size(); ++i) { + setter(i + 2, unpacked_ctxs[i]); + } + TVMRetValue rv; + pf->CallPacked(TVMArgs(values.data(), codes.data(), args_size), &rv); + Module mod = rv.operator Module(); + // debug graph runtime is one child class of graph runtime. + SetParams(const_cast<GraphRuntime*>(mod.as<GraphRuntime>()), factory_module->GetParams()); + return mod; +} + +Module GraphRuntimeFactory::SelectModule(const std::string& name) { Review comment: The name Select is a bit confusing, let us fold into RuntimeCreate and DebugRuntime create instead, so that we don't need to create a separate factory module ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
