tqchen commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454075454
##########
File path: src/runtime/module.cc
##########
@@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name,
bool query_imports)
PackedFunc pf = self->GetFunction(name, GetObjectPtr<Object>(this));
if (pf != nullptr) return pf;
if (query_imports) {
- for (Module& m : self->imports_) {
- pf = m->GetFunction(name, m.data_);
- if (pf != nullptr) return pf;
Review comment:
`m->` is a shorthand for` =m.operator->()` so it should work. We are not
doing `m.GetFunction here`.
GetFunction was overloaded for ModuleNode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
