giuseros commented on a change in pull request #5980:
URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454423764
##########
File path: src/target/intrin_rule.cc
##########
@@ -115,6 +115,51 @@ TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.isinf")
*rv = isinf(call->args[0]);
});
+TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.qmuls")
+ .set_body([](const TVMArgs& args, TVMRetValue* rv) {
+ using tir::make_const;
+
+ PrimExpr e = args[0];
+ const tir::CallNode* call = e.as<tir::CallNode>();
+ CHECK(call != nullptr);
+
+ PrimExpr x = call->args[0];
+ PrimExpr y = call->args[1];
+ PrimExpr q = call->args[2];
+ PrimExpr s = call->args[3];
+
+ // Only int32 types are supported (any number of lanes is allowed)
+ CHECK(x.dtype().code() == DLDataTypeCode::kDLInt && x.dtype().bits() ==
32);
+ CHECK(y.dtype().code() == DLDataTypeCode::kDLInt && y.dtype().bits() ==
32);
+ CHECK(s.dtype().code() == DLDataTypeCode::kDLInt && s.dtype().bits() ==
32);
+
+ DataType hp_dtype = DataType::Int(64, x.dtype().lanes());
+ DataType lp_dtype = DataType::Int(32, x.dtype().lanes());
+
+ // 1) Calculating the integer multiplier and integer shift
+ PrimExpr zero = make_const(s.dtype(), 0);
+ PrimExpr left_shift = tir::Select((s > zero), s, zero);
+ PrimExpr right_shift = tir::Select(s > zero, zero, -s);
+
+ // 2) Multiply the integer multiplier
+ x = tir::Select(left_shift != zero, x << cast(hp_dtype, left_shift),
cast(hp_dtype, x));
+
+ // 3) Perform the multiplication in higher precision.
+ x = x * y;
Review comment:
I think `y` gets automatically promoted to `int64`. However, I guess
being explicit doesn't hurt !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
