giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454543214
########## File path: include/tvm/tir/op.h ########## @@ -552,6 +552,24 @@ TVM_DLL PrimExpr trunc(PrimExpr x); */ TVM_DLL PrimExpr LargeUIntImm(DataType dtype, int64_t low, int64_t high); +/*! + * \brief Execute a multiplication between two Q-numbers x and y + * followed by a right shift s. The mathematical expression is: + * + * out = round(x*y*2^-s) + * + * More about Q-numbers here: https://en.wikipedia.org/wiki/Q_(number_format) + * + * The rounding rule is to the nearest value, rounding half up + * (i.e., round(x.1) = x and round (x.5) = x+1) + * \param x first Q-number + * \param y second Q-number + * \param q Q-ness of x and y Review comment: I added the constraint of `q>0` in the doc string of the function (both in python and c++). The problem is that this intrinsic is vectorized and `q` becomes a vector. In order to check `q>0` within the intrinsic, I would need to go through a reduction (which seems a bit expensive for a simple check). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
