jroesch commented on a change in pull request #6162:
URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r465347178
##########
File path: include/tvm/relay/adt.h
##########
@@ -309,8 +309,9 @@ class Match : public Expr {
* \param data the input being deconstructed.
* \param clauses The clauses for matching.
* \param complete Indicate if this match is complete.
+ * \param span The span of the expression.
*/
- TVM_DLL Match(Expr data, tvm::Array<Clause> clauses, bool complete = true);
+ TVM_DLL Match(Expr data, tvm::Array<Clause> clauses, bool complete = true,
Span span = Span());
Review comment:
I actually don't want spans to be optional if possible, but currently we
need to migrate to setting them everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
