jroesch commented on a change in pull request #6162: URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r463858441
########## File path: src/parser/meta_ref.cc ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file src/parser/meta_ref.cc + * \brief An operator which allows forward referencing a yet-to-be parsed meta table reference. + */ + +#include "./meta_ref.h" + +#include <topi/elemwise.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/op.h> +#include <tvm/relay/op_attr_types.h> +#include <tvm/relay/transform.h> + +namespace tvm { +namespace parser { + +using tvm::relay::transform::CreateFunctionPass; +using tvm::transform::PassContext; + +TVM_REGISTER_NODE_TYPE(MetaRefAttrs); Review comment: I think this is a taste thing, I would rather have more files that are clearly delinated then put a lot of random things in the same file. Even if they are related the sheer amount of code in many files often confuses new TVM contributors as you might be wanting to just show one algorithm in the file, but there are a lot of support data strcutures and functions inlined into the file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
