weberlo commented on pull request #5940: URL: https://github.com/apache/incubator-tvm/pull/5940#issuecomment-672323092
> @weberlo Will this affect the original pipeline when the config `partition_conversions` is `disabled`? @ZihengJiang It won't affect the original pipeline, since we just return the `mod` [here](https://github.com/apache/incubator-tvm/pull/5940/files#diff-0ca944afca91e5a6d46981a4ac9e3dd6R378) when `partition_conversions` is `disabled`. > Nice work @weberlo, do can we add a partition_conversions=disabled unit test as well? It's implicitly tested in [this helper function](https://github.com/apache/incubator-tvm/pull/5940/files#diff-c82103045cf6ee84456fa38e019e074fR143-R146). I explicitly set it to `disabled` to make it clearer in the most recent commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
