weberlo commented on pull request #5940:
URL: https://github.com/apache/incubator-tvm/pull/5940#issuecomment-673580414


   > @weberlo I believe we would like a general approach to achieve the 
partitioning in the future, but I am fine with the PR in the current stage. I 
will approve it after it pass the tests.
   
   I agree the current implementation is suboptimal, and it would be much 
better to integrate it more closely with the quantization pass itself.  I went 
with the approach in this PR, because you're in the process of making 
significant changes to quantization, and this approach should be robust to 
those changes.  We should certainly revisit this feature once your changes land 
though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to