hypercubestart commented on a change in pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r469683893



##########
File path: python/tvm/relay/backend/_backend.py
##########
@@ -90,7 +90,11 @@ def _tensor_value_repr(tvalue):
 
 @tvm._ffi.register_func("relay._constant_repr")
 def _tensor_constant_repr(tvalue):
-    return str(tvalue.data.asnumpy())
+    # TODO(gus) do this in a smarter way

Review comment:
       we decided that this is an easy way with low overhead and gives correct 
information to users. Could be changed in the future if the need from users 
arises

##########
File path: python/tvm/relay/backend/_backend.py
##########
@@ -90,7 +90,11 @@ def _tensor_value_repr(tvalue):
 
 @tvm._ffi.register_func("relay._constant_repr")
 def _tensor_constant_repr(tvalue):
-    return str(tvalue.data.asnumpy())
+    # TODO(gus) do this in a smarter way
+    try:

Review comment:
       yep done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to