hypercubestart commented on a change in pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r475153732



##########
File path: python/tvm/target/datatype.py
##########
@@ -94,33 +100,47 @@ class name (e.g. Add, LE, Cast).
     target : str
         The name of codegen target.
 
-    type_name : str
+    src_type_name : str
         The name of the custom datatype, e.g. posit (but not custom[posit]8).

Review comment:
       done!

##########
File path: src/target/datatype/registry.h
##########
@@ -60,7 +62,7 @@ class Registry {
    * manually allocated by the user, and the user must ensure that no two 
custom types share the
    * same code. Generally, this should be straightforward, as the user will be 
manually registering
    * all of their custom types.
-   * \param type_name The name of the type, e.g. "bfloat"
+   * \param type_name The name of the type, e.g. "posit"

Review comment:
       done!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to