junrushao1994 commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r470847640
########## File path: include/tvm/ir/diagnostic.h ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file diagnostic.h + * \brief A new diagnostic interface for TVM error reporting. + * + * A prototype of the new diagnostic reporting interface for TVM. + * + * Eventually we hope to promote this file to the top-level and + * replace the existing errors.h. + */ + +#ifndef TVM_IR_DIAGNOSTIC_H_ +#define TVM_IR_DIAGNOSTIC_H_ + +#include <tvm/ir/span.h> +#include <tvm/ir/module.h> +#include <tvm/parser/source_map.h> +#include <tvm/runtime/container.h> +#include <tvm/runtime/object.h> +#include <tvm/support/logging.h> + +#include <fstream> +#include <string> +#include <utility> +#include <vector> + +namespace tvm { + +using tvm::parser::SourceMap; + +static const char* kTVM_INTERNAL_ERROR_MESSAGE = "An internal invariant was violated during the execution of TVM" \ + "please read TVM's error reporting guidelines at discuss.tvm.ai/thread"; Review comment: ```suggestion static const char* kTVM_INTERNAL_ERROR_MESSAGE = "An internal invariant was violated during the execution of TVM." \ "Please read TVM's error reporting guidelines at discuss.tvm.ai/thread"; ``` ########## File path: include/tvm/ir/diagnostic.h ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file diagnostic.h + * \brief A new diagnostic interface for TVM error reporting. + * + * A prototype of the new diagnostic reporting interface for TVM. + * + * Eventually we hope to promote this file to the top-level and + * replace the existing errors.h. + */ + +#ifndef TVM_IR_DIAGNOSTIC_H_ +#define TVM_IR_DIAGNOSTIC_H_ + +#include <tvm/ir/span.h> +#include <tvm/ir/module.h> +#include <tvm/parser/source_map.h> +#include <tvm/runtime/container.h> +#include <tvm/runtime/object.h> +#include <tvm/support/logging.h> + +#include <fstream> +#include <string> +#include <utility> +#include <vector> + +namespace tvm { + +using tvm::parser::SourceMap; + +static const char* kTVM_INTERNAL_ERROR_MESSAGE = "An internal invariant was violated during the execution of TVM" \ + "please read TVM's error reporting guidelines at discuss.tvm.ai/thread"; Review comment: ```suggestion static const char* kTVM_INTERNAL_ERROR_MESSAGE = "An internal invariant was violated during the execution of TVM. " \ "Please read TVM's error reporting guidelines at discuss.tvm.ai/thread"; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
