jwfromm commented on a change in pull request #6315:
URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474239652
##########
File path: tests/python/unittest/test_target_target.py
##########
@@ -80,7 +80,31 @@ def test_target_create():
assert tgt is not None
+def test_target_config():
+ """
+ Test that constructing a target from a dictionary works.
+ """
+ target_config = {
Review comment:
Can you expand on this a little? Do you mean add testing that confirms
it fails when invalid attribute types are provided?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
