comaniac commented on a change in pull request #6315:
URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474254880
##########
File path: tests/python/unittest/test_target_target.py
##########
@@ -80,7 +80,31 @@ def test_target_create():
assert tgt is not None
+def test_target_config():
+ """
+ Test that constructing a target from a dictionary works.
+ """
+ target_config = {
Review comment:
I just meant we should also test the attribute which type is a map.
Since one purpose of testing Python binding is to make sure we can correctly
pass supported data structures to the C++ container. Specifically, the Python
version of this test:
https://github.com/apache/incubator-tvm/blob/master/tests/cpp/target_test.cc#L121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
