leandron edited a comment on pull request #6315:
URL: https://github.com/apache/incubator-tvm/pull/6315#issuecomment-678292796
I tested it integrating with my ongoing PR #6302 and it works.
One small comment is that I didn't see here a test checking that plain JSON
strings, such as `{ "kind": "llvm" }`. Would that make sense to add one, to
guarantee the internal behaviour is validated, and the
`_ffi_api.TargetFromConfig` branch is also covered? Let me know in case I'm
missing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
