hypercubestart commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r475920138
########## File path: python/tvm/relay/frontend/change_datatype.py ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# pylint: disable=unused-argument +"""Change Datatype Pass""" +from ..function import Function +from ..expr_functor import ExprMutator +from ..transform.transform import function_pass +from ..expr import var, bind + +# TODO(@gussmith23) what's the right opt level here? +@function_pass(opt_level=0) Review comment: yeah I think this is fine. opt_level is only relevant when used in transform.Sequential which determines which transforms can be run. But our use case doesn't really involve transform.Sequential, so any opt_level should be okay here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
