junrushao1994 commented on a change in pull request #6369:
URL: https://github.com/apache/incubator-tvm/pull/6369#discussion_r485270637
##########
File path: python/tvm/target/target.py
##########
@@ -126,7 +172,7 @@ def cuda(model='unknown', options=None):
Additional options
"""
opts = _merge_opts(['-model=%s' % model], options)
- return _ffi_api.TargetCreate("cuda", *opts)
+ return Target(" ".join(["cuda"] + opts))
Review comment:
I was thinking about this too, but it turns out to be a bit ad-hoc too
(in terms of types and those usage). Maybe in the future, we should deprecate
those creation helpers, and use target config dict directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
