junrushao1994 commented on a change in pull request #6369:
URL: https://github.com/apache/incubator-tvm/pull/6369#discussion_r485278553
##########
File path: python/tvm/target/target.py
##########
@@ -37,22 +38,67 @@ class Target(Object):
Note
----
- Do not use class constructor, you can create target using the following
functions
+ You can create target using the constructor or the following functions
- - :py:func:`tvm.target.create` create target from string
- :py:func:`tvm.target.arm_cpu` create arm_cpu target
- :py:func:`tvm.target.cuda` create CUDA target
- :py:func:`tvm.target.rocm` create ROCM target
- :py:func:`tvm.target.mali` create Mali target
- :py:func:`tvm.target.intel_graphics` create Intel Graphics target
"""
+ def __init__(self, tag_or_str_or_dict):
+ """Construct a TVM target object from
+ 1) Raw target string
+ 2) Target config dict
+ 3) Target tag
+
+ Parameters
+ ----------
+ tag_or_str_or_dict : str or dict
Review comment:
I was not quite familiar with in-doc type annotation. Does the following
one work? `Union[str, Dict[str, Any]]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
