junrushao1994 commented on a change in pull request #6369: URL: https://github.com/apache/incubator-tvm/pull/6369#discussion_r485289928
########## File path: include/tvm/target/tag.h ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/target/tag.h + * \brief Target tag registry + */ +#ifndef TVM_TARGET_TAG_H_ +#define TVM_TARGET_TAG_H_ + +#include <tvm/node/attr_registry_map.h> +#include <tvm/node/node.h> +#include <tvm/target/target.h> + +#include <utility> + +namespace tvm { + +/*! \brief A target tag */ +class TargetTagNode : public Object { + public: + /*! \brief Name of the target */ + String name; + /*! \brief Config map to generate the target */ + Map<String, ObjectRef> config; + + void VisitAttrs(AttrVisitor* v) { + v->Visit("name", &name); + v->Visit("config", &config); + } + + static constexpr const char* _type_key = "TargetTag"; + TVM_DECLARE_FINAL_OBJECT_INFO(TargetTagNode, Object); + + private: + /*! \brief Return the index stored in attr registry */ + uint32_t AttrRegistryIndex() const { return index_; } + /*! \brief Return the name stored in attr registry */ + String AttrRegistryName() const { return name; } + /*! \brief Index used for internal lookup of attribute registry */ + uint32_t index_; + + template <typename, typename> + friend class AttrRegistry; + template <typename> + friend class AttrRegistryMapContainerMap; + friend class TargetTagRegEntry; +}; + +/*! + * \brief Managed reference class to TargetTagNode + * \sa TargetTagNode + */ +class TargetTag : public ObjectRef { + public: + /*! + * \brief Retrieve the Target given it the name of target tag + * \param target_tag_name Name of the target tag + * \return The Target requested + */ + TVM_DLL static Optional<Target> Get(const String& target_tag_name); + /*! + * \brief List all names of the existing target tags + * \return A dictionary that maps tag name to the concrete target it corresponds to + */ + TVM_DLL static Map<String, Target> ListTags(); + /*! + * \brief Add a tag into the registry + * \param name Name of the tag + * \param config The target config corresponding to the tag + * \param override Allow overriding existing tags + * \return Target created with the tag + */ + TVM_DLL static Target AddTag(String name, Map<String, ObjectRef> config, bool override); Review comment: First of all, there are some mistakes in the doc string of "ListTags". The description should be "List all names of target tags and their corresponding target". > I suppose TargetTag maintains the target config of one target tag, but why it has those two APIs that look like managing all the tags? Because it is a static method. Similar method exists like `Op::Get`, `runtime::Registry::ListNames`, and I am following the idiom. Let's also clarify the terminology here: * Target tag is a TVM object that contains the tag's name and the config dict * Target name is a string * Target config dict is a Map<String, Object> which can be used to generate the corresponding Target. To keep the interface minimalist, I actually do not prefer users to directly interact with the Target tag registry. We was thinking if it is possible to make "tag.h" internal... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
