junrushao1994 edited a comment on pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691312663
Hey @tmoreau89 @rkimball, I just came up with an idea!
To be more consistent with the cmake-way (cross-platform/compiler with
unified API), it might be have a separate file, like
"cmake/util/WarningFlags.cmake", which provides a variable ${TVM_WARNING_FLAGS}
if this file is included.
Inside this file, we check the compiler version (GCC, Clang, MSVC, etc), and
for each compiler version, we may have a list of candidate warning flags to be
added. Then we iterator through the list and check if this flag exists. If it
does, then we add it to the result ${TVM_WARNING_FLAGS}.
Then, from the outside users' perspective, it is a cross-platform way to
provide a list of warning flags, which is very cmake :-)
BTW, personally I don't prefer using "-Weverything" plus canceling some
flags, but would be great to choose the combination of specific flags instead,
which might make the list clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
