rkimball commented on pull request #6456: URL: https://github.com/apache/incubator-tvm/pull/6456#issuecomment-691332209
@junrushao1994 I like the idea for adding the WarningFlags.cmake file. I had it that way in a different project and it worked well there so I will move the flags there. The error flags are specific to clang and they do add new flags with new releases of clang which is why I like the -Weverything approach. This way if there is a new warning flag added we will know because we will see the new warnings. That's the theory anyway. I'm looking for an exhaustive list of warning messages to see how many there are. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
