yongwww commented on pull request #6472: URL: https://github.com/apache/incubator-tvm/pull/6472#issuecomment-693109650
> > @masahi Just checked the op list under torch.Tensor, there are a bunch of inplace ops there, seems the op with suffix `_` is inplace one, https://discuss.pytorch.org/t/how-to-identify-the-in-place-operation-in-pytorch/18592. > > Yes, that is also my understanding. Removing and not supporting `copy_` sounds good, as it is commonly used for a pattern we cannot support, but for other inplace ops like `clamp_` and others already in the frontend, I think we can keep them. What do you think @t-vi ? sounds good to me. A **hacky** way to detect the copy_ case is to use "select->view->copy_" as pattern, and return the vbut I it is on ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
