yongwww edited a comment on pull request #6472: URL: https://github.com/apache/incubator-tvm/pull/6472#issuecomment-693760843
@masahi @t-vi seems the translation for every inplace op has similar issue as copy_, considering the translation works for some cases (those w/o real inplace), I would like to still keep copy_ and clamp_ in this pr, and add warning for all implace op. How do you think? getting more model supported is the first step for us, if overall inference result is not correct, then one of the first things is to look at the implace op mapping warning, does this make sense to you? or do I need to remove `copy_` and `clamp_`? we did encounter some models with clamp_ and some some other implace op from customers, and we didn't see the accuracy issue frequently, having implace op translation offered value for us. Looking forward to a general and well-performing solution for implace support in tvm in a long term ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
