FrozenGene commented on a change in pull request #6578:
URL: https://github.com/apache/incubator-tvm/pull/6578#discussion_r497209168
##########
File path: tests/python/driver/tvmc/conftest.py
##########
@@ -110,10 +112,33 @@ def onnx_resnet50():
@pytest.fixture(scope="session")
def tflite_compiled_module_as_tarfile(tmpdir_factory):
+
+ # Not all CI environments will have TFLite installed
+ # so we need to safely skip this fixture that will
+ # crash the tests that rely on it.
+ # As this is a pytest.fixture, we cannot take advantage
+ # of pytest.importorskip. Using the block below instead.
+ try:
+ import tflite
+ except ImportError:
+ print("Cannot import tflite, which is required by
tflite_compiled_module_as_tarfile.")
+ return ""
+
target_dir = tmpdir_factory.mktemp("data")
graph, lib, params, _ = get_sample_compiled_module(target_dir)
Review comment:
Just find one very important place here. Do we still use old api of
tvm.build? In new module-based api, we will only generate one `lib`, the
`graph` and `params` is serialized into `lib`. Of course, we will still have
one interface to make users get `params` separately to meet the need of network
only updates weight only. We should notice that old api will be removed in the
next release, so we shouldn't use it in the new feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
