leandron commented on a change in pull request #6578:
URL: https://github.com/apache/incubator-tvm/pull/6578#discussion_r497298591
##########
File path: tests/python/driver/tvmc/conftest.py
##########
@@ -110,10 +112,33 @@ def onnx_resnet50():
@pytest.fixture(scope="session")
def tflite_compiled_module_as_tarfile(tmpdir_factory):
+
+ # Not all CI environments will have TFLite installed
+ # so we need to safely skip this fixture that will
+ # crash the tests that rely on it.
+ # As this is a pytest.fixture, we cannot take advantage
+ # of pytest.importorskip. Using the block below instead.
+ try:
+ import tflite
+ except ImportError:
+ print("Cannot import tflite, which is required by
tflite_compiled_module_as_tarfile.")
+ return ""
+
target_dir = tmpdir_factory.mktemp("data")
graph, lib, params, _ = get_sample_compiled_module(target_dir)
Review comment:
This refers to `compile`, which is the mechanism we are using here to
generate this test fixture. The underlying API here is `relay.build` (not
`tvm.build`, as far as I could check).
Here is the relevant snippet:
https://github.com/apache/incubator-tvm/blob/fde8d432acd2d7964607c4f9216720298db04007/python/tvm/driver/tvmc/compiler.py#L192-L203
With regards to the `params` embedded into `lib`, I think this is something
we could improve in a future PR? It is likely to have more implications in the
tool, that I'd need to investigate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
