iiahim commented on a change in pull request #6600:
URL: https://github.com/apache/incubator-tvm/pull/6600#discussion_r498377823
##########
File path: python/tvm/contrib/cc.py
##########
@@ -103,7 +105,8 @@ def get_target_triple():
# assign so as default output format
create_shared.output_format = "so" if sys.platform != "win32" else "dll"
create_shared.get_target_triple = get_target_by_dump_machine(
- "g++" if sys.platform == "darwin" or sys.platform.startswith("linux") else
None
+ os.environ["CXX"] if "CXX" in os.environ.keys() else \
+ "g++" if sys.platform == "darwin" or sys.platform.startswith("linux")
else None
Review comment:
Also ... is any reason to use g++ and not c++?
While I think getting it from the env if it has values, c++ seems to work on
Linux (Ubuntu & Centos) and FreeBSD. I don't have access to MacOS to test it
there.
Would you accept to change g++ -> c++ as default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
