junrushao1994 commented on a change in pull request #6600:
URL: https://github.com/apache/incubator-tvm/pull/6600#discussion_r498391587
##########
File path: python/tvm/contrib/cc.py
##########
@@ -103,7 +105,8 @@ def get_target_triple():
# assign so as default output format
create_shared.output_format = "so" if sys.platform != "win32" else "dll"
create_shared.get_target_triple = get_target_by_dump_machine(
- "g++" if sys.platform == "darwin" or sys.platform.startswith("linux") else
None
+ os.environ["CXX"] if "CXX" in os.environ.keys() else \
+ "g++" if sys.platform == "darwin" or sys.platform.startswith("linux")
else None
Review comment:
Typically we just use g++. On macos, g++ is symlinked to clang++, so it
is fine imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
