manupa-arm commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r530634569
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
That is true for Packing of Imports which get unpacked in the runtime to
recreate the runtime modules. I guess the question is would that be the only
purpose of the metadata module ? since it is named as metadata module. Thus,
here I am not suggesting to pack, instead make the metadata module generate the
func registry in the artifact (which is devc.cc/o) that it uses to pack the
imports.
As in packing and unpacking of imported runtime modules being just part of
the metadata module, can it also hold the func registry as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
