manupa-arm commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r530838065
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
So this is my understanding, metadata module will pack imported modules'
constants to devc.{object_format) **if they implement "get_symbol" and
"get_const_vars"**, otherwise its virtually doing nothing (Correct me if I am
wrong, @zhiics). In this case, when we want to create external c-source modules
from our external codegen, metadata module's load process should be virtually
harmless -- as the SavetoBinary will almost write nothing to
devc.{object_format} file (but there are things being written)
So my question is since metadata module holds all the modules (DSO -- llvm/c
modules -- and non-DSO exportable modules) can generate the func_registry as
well. Do we really want an another entity to deal with model-level metadata ? I
would really appreciate a way forward on this. also : @tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
