manupa-arm commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r532802384
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
Sorry, I am not sure I follow. Here what I meant is we could create the
function registry in a different source that captures the function names from
all the runtime modules and the packed func is also used only in the compile
time to create c-source metadata module. That would be exactly same as what you
would've produced inside the main "c"/"llvm" module except its created in a
different module that has access to all the runtime modules created -- thus
including all the function names each runtime module consist of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
