manupa-arm commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r532788103
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
No I've already removed the FuncRegistry from codegen_host_c and
codegen_llvm and make the runtime modules expose a packed func named :
"get_func_names" -- we can discuss the best name for it , I am not good at
naming stuff :p . So the CSourceMetadata module will use that from the runtime
modules and create a single func registry as a seperate source to be linked
together. Still fixing some tests, I ll put it up soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
