FrozenGene commented on a change in pull request #7020:
URL: https://github.com/apache/tvm/pull/7020#discussion_r534731618
##########
File path: include/tvm/auto_scheduler/search_task.h
##########
@@ -44,17 +44,16 @@ class HardwareParamsNode : public Object {
int cache_line_bytes;
// GPU related parameters got from device query API
-
- /*! \brief The max shared memory per block. */
- int max_shared_memory_per_block{INT32_MAX};
- /*! \brief The max register memory per block. */
- int max_registers_per_block{INT32_MAX};
- /*! \brief The max threads per block. */
- int max_threads_per_block{INT32_MAX};
+ /*! \brief The max shared memory per block in bytes. */
+ int max_shared_memory_per_block;
+ /*! \brief The max number of register per block. */
+ int max_registers_per_block;
+ /*! \brief The max number of threads per block. */
+ int max_threads_per_block;
Review comment:
What I meant is we add code wrapper using `attr` like this:
```python
@property
def max_registers_per_block(self):
"""Return max registers per block"""
return self._GetDeviceAttr(self.device_type, self.device_id, 9)
```
Otherwise we access these property will not be convenient like other
property `max_shared_memory_per_block` supported before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
