merrymercy commented on a change in pull request #7020:
URL: https://github.com/apache/tvm/pull/7020#discussion_r535444853
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -168,15 +175,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
else: # group_conv2d
if layout == "NCHW":
assert kernel_layout == "OIHW"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
Review comment:
```suggestion
logger.warning("group_conv2d is not optimized for x86 with
autotvm.")
```
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -168,15 +175,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
else: # group_conv2d
if layout == "NCHW":
assert kernel_layout == "OIHW"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
strategy.add_implementation(
wrap_compute_conv2d(topi.nn.group_conv2d_nchw,
has_groups=True),
wrap_topi_schedule(topi.generic.schedule_group_conv2d_nchw),
name="group_conv2d_nchw.generic",
)
elif layout == "NHWC":
assert kernel_layout == "HWIO"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
Review comment:
```suggestion
logger.warning("group_conv2d is not optimized for x86 with
autotvm.")
```
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -117,14 +118,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
return conv2d_NCHWc_strategy_cpu(attrs, inputs, out_type, target)
elif layout == "NHWC":
assert kernel_layout == "HWIO"
+ if not is_auto_scheduler_enabled():
+ logger.warning("conv2d NHWC layout is not optimized for x86 in
autotvm.")
Review comment:
```suggestion
logger.warning("conv2d NHWC layout is not optimized for x86
with autotvm.")
```
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -117,14 +118,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
return conv2d_NCHWc_strategy_cpu(attrs, inputs, out_type, target)
elif layout == "NHWC":
assert kernel_layout == "HWIO"
+ if not is_auto_scheduler_enabled():
+ logger.warning("conv2d NHWC layout is not optimized for x86 in
autotvm.")
strategy.add_implementation(
wrap_compute_conv2d(topi.nn.conv2d_nhwc,
need_auto_scheduler_layout=True),
wrap_topi_schedule(topi.x86.schedule_conv2d_nhwc),
name="conv2d_nhwc.x86",
)
elif layout == "HWCN":
assert kernel_layout == "HWIO"
- logger.warning("conv2d HWCN layout is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("conv2d HWCN layout is not optimized for x86 in
autotvm.")
Review comment:
```suggestion
logger.warning("conv2d HWCN layout is not optimized for x86
with autotvm.")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
