masahi commented on pull request #7023: URL: https://github.com/apache/tvm/pull/7023#issuecomment-738362461
Also, now that we are encapsulating each converter inside a class, I think it is ok to remove underscore `_` in each converter method, if you prefer (replace `def _` -> `def `, `self._` -> `self.`). I'm fine either way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
