masahi commented on pull request #7023: URL: https://github.com/apache/tvm/pull/7023#issuecomment-738619723
1. To avoid confusion when we add a new converter, I think we should make everything staticmethod or regular one. Since this class is supposed to be a singleton, staticmethod makes sense to me. 2. Yes, the arguments of each op converter are supposed to be `inputs, input_types`. If you add another arg like `name, inputs, input_types` I'd say it is already not consistent. So I prefer lifting `name` arg to a wrapper function and returning a new impl function. I think being able to remove all the `functools.partial(...)` is a big plus. 3. Ok we can do that later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
