masahi commented on a change in pull request #7074:
URL: https://github.com/apache/tvm/pull/7074#discussion_r539826881
##########
File path: src/relay/qnn/op/convolution.cc
##########
@@ -57,22 +59,27 @@ bool QnnConv2DRel(const Array<Type>& types, int num_inputs,
const Attrs& attrs,
ICHECK(param->out_dtype.bits() > 0) << "Output dtype bits should be greater
than 0.";
// Check the types of scale and zero points.
+ for (size_t i = 2; i < 5; ++i) {
Review comment:
I think @mbrookhart added check for those types checked by
`ICHECK(IsScalarType(...))` below. There is no check for weight scale being
scalar because weight scale can be a vector for per channel case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
