mbrookhart commented on a change in pull request #7074:
URL: https://github.com/apache/tvm/pull/7074#discussion_r539827184
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -256,13 +256,20 @@ Expr RequantizeQnnCanonicalize(const Attrs& attrs, const
Array<Expr>& new_args,
*/
bool RequantizeRel(const Array<Type>& types, int num_inputs, const Attrs&
attrs,
const TypeReporter& reporter) {
+ // Expected Types: data, input_scale, input_zero_point, output_scale,
output_zero_point, output
ICHECK_EQ(types.size(), 6);
const auto* data = types[0].as<TensorTypeNode>();
if (data == nullptr) {
return false;
}
+ // Check the scale and zero point types
+ for (size_t i = 3; i < 5; ++i) {
Review comment:
A few lines down you'll see assignments for input scale and input zero
point, but checks on output_scale and output_zero_point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
