Laurawly commented on a change in pull request #7123:
URL: https://github.com/apache/tvm/pull/7123#discussion_r550403082
##########
File path: python/tvm/topi/vision/nms.py
##########
@@ -213,7 +213,7 @@ def get_valid_counts(data, score_threshold=0, id_index=0,
score_index=1):
out_indices: tvm.te.Tensor or numpy NDArray
Related index in input data.
"""
- if isinstance(score_threshold, float):
+ if isinstance(score_threshold, (float, int)):
Review comment:
Just curious what's the scenario for score_threshold to be an int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
