jwfromm commented on a change in pull request #7300:
URL: https://github.com/apache/tvm/pull/7300#discussion_r559223702
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -1065,7 +1062,7 @@ def _impl_v9(cls, inputs, attr, params):
scale_w,
layout=layout,
method=method,
- align_corners=align_corners,
+ align_corners=False,
Review comment:
Upsample was one of the tests that was against our numpy implementation
rather than onnxruntime. Checking tvm's output directly against onnx revealed
that we were producing incorrect values for bilinear interpolation and always
using `align_corners=False` made the outputs match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
