masahi commented on a change in pull request #7300:
URL: https://github.com/apache/tvm/pull/7300#discussion_r559262920
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -1065,7 +1062,7 @@ def _impl_v9(cls, inputs, attr, params):
scale_w,
layout=layout,
method=method,
- align_corners=align_corners,
+ align_corners=False,
Review comment:
Interesting. The current ONNX spec says Upsample does only nearest
https://github.com/onnx/onnx/blob/master/docs/Operators.md#Upsample, while
older versions had `mode` parameter. In either case it doesn't specify what to
do with `align_corners`.
Since the spec is dubious and upsample is now deprecated, perhaps we should
also warn that upsample is deprecated? Maybe we should always use
`method=nearest` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
