altanh commented on pull request #7370: URL: https://github.com/apache/tvm/pull/7370#issuecomment-769629848
Hah, got it, I'm in favor of just deleting that test :joy: but I guess someone might depend on this behavior. Actually... we could do the `negs++` counter thing in the handling for `-` branch and only collapse them if we eventually hit a digit or `inff`, otherwise reset `pos` and return a single `kMinus`. I understand Jared's comment now about the "multi-token return" as this will be incredibly slow if someone decides to write a lot of minus signs and not put a number after. This approach should be able to avoid modifying the tokenization loop. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
